fix: for newer version so of octokitpy-routes '*' is included in the

webhook data published

fixes #108
This commit is contained in:
Kyle Hornberg
2020-12-10 16:14:53 -06:00
parent 1314f16096
commit 9295ffa5d5
2 changed files with 12 additions and 1 deletions
+1 -1
View File
@@ -21,7 +21,7 @@ def valid_guid(guid):
def valid_event(event, events):
return event in webhook_names or "*" in webhook_names
return event in webhook_names
def valid_user_agent(ua):
+11
View File
@@ -116,3 +116,14 @@ class TestWebhook(object):
payload = ""
secret = "secret"
assert webhook.verify(headers, payload, secret, events=["*"], return_app_id=True)
def test_must_have_a_valid_event(self):
headers = {
"X-Hub-Signature": "sha1=25af6174a0fcecc4d346680a72b7ce644b9a88e8",
"X-GitHub-Event": "blah",
"X-GitHub-Delivery": "72d3162f-cc78-11e3-81ab-4c9367dc0958",
}
payload = ""
secret = "secret"
events = ["push"]
assert webhook.verify(headers, payload, secret, events=events) is False