From 9295ffa5d521480ccd6648557a0aa280a42d96e2 Mon Sep 17 00:00:00 2001 From: Kyle Hornberg Date: Thu, 10 Dec 2020 16:14:53 -0600 Subject: [PATCH] fix: for newer version so of octokitpy-routes '*' is included in the webhook data published fixes #108 --- src/octokit/webhook.py | 2 +- tests/test_webhook.py | 11 +++++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/src/octokit/webhook.py b/src/octokit/webhook.py index f3c070a..2679c39 100644 --- a/src/octokit/webhook.py +++ b/src/octokit/webhook.py @@ -21,7 +21,7 @@ def valid_guid(guid): def valid_event(event, events): - return event in webhook_names or "*" in webhook_names + return event in webhook_names def valid_user_agent(ua): diff --git a/tests/test_webhook.py b/tests/test_webhook.py index e515b6c..9c58917 100644 --- a/tests/test_webhook.py +++ b/tests/test_webhook.py @@ -116,3 +116,14 @@ class TestWebhook(object): payload = "" secret = "secret" assert webhook.verify(headers, payload, secret, events=["*"], return_app_id=True) + + def test_must_have_a_valid_event(self): + headers = { + "X-Hub-Signature": "sha1=25af6174a0fcecc4d346680a72b7ce644b9a88e8", + "X-GitHub-Event": "blah", + "X-GitHub-Delivery": "72d3162f-cc78-11e3-81ab-4c9367dc0958", + } + payload = "" + secret = "secret" + events = ["push"] + assert webhook.verify(headers, payload, secret, events=events) is False