actions/codeql-action
1
0
Fork 0
mirror of https://github.com/github/codeql-action synced 2026-05-25 15:00:36 +03:00
Code Issues Packages Projects Releases Wiki Activity

Don't use Zstandard bundles on Windows

Browse Source 
In testing, gzip performs better than Zstandard on Windows.
This commit is contained in:
Henry Mercer
2024-10-10 19:24:32 +01:00
parent 9d1e406cd6
commit eefb943f7e
7 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/__zstd-bundle-fallback.yml
Generated
-2
View File
@@ -29,8 +29,6 @@ jobs:
include:
- os: macos-latest
version: linked
- os: windows-latest
version: linked
- os: ubuntu-latest
version: linked
name: Zstandard bundle fallback
.github/workflows/__zstd-bundle.yml
Generated
-2
View File
@@ -29,8 +29,6 @@ jobs:
include:
- os: macos-latest
version: linked
- os: windows-latest
version: linked
- os: ubuntu-latest
version: linked
name: Zstandard bundle
lib/setup-codeql.js
Generated
+4 -1
View File
@@ -553,7 +553,10 @@ function sanitizeUrlForStatusReport(url) {
: "sanitized-value";
}
async function useZstdBundle(cliVersion, features, tarSupportsZstd) {
return (tarSupportsZstd &&
return (
// In testing, gzip performs better than zstd on Windows.
process.platform !== "win32" &&
tarSupportsZstd &&
semver.gte(cliVersion, feature_flags_1.CODEQL_VERSION_ZSTD_BUNDLE) &&
!!(await features.getValue(feature_flags_1.Feature.ZstdBundle)));
}
lib/setup-codeql.js.map
+1 -1
View File
File diff suppressed because one or more lines are too long
pr-checks/checks/zstd-bundle-fallback.yml
-1
View File
@@ -4,7 +4,6 @@ versions:
- linked
operatingSystems:
- macos
- windows
- ubuntu
env:
CODEQL_ACTION_ZSTD_BUNDLE: true
pr-checks/checks/zstd-bundle.yml
-1
View File
@@ -4,7 +4,6 @@ versions:
- linked
operatingSystems:
- macos
- windows
- ubuntu
env:
CODEQL_ACTION_ZSTD_BUNDLE: true
src/setup-codeql.ts
+2
View File
@@ -823,6 +823,8 @@ async function useZstdBundle(
tarSupportsZstd: boolean,
): Promise<boolean> {
return (
// In testing, gzip performs better than zstd on Windows.
process.platform !== "win32" &&
tarSupportsZstd &&
semver.gte(cliVersion, CODEQL_VERSION_ZSTD_BUNDLE) &&
!!(await features.getValue(Feature.ZstdBundle))