Address review comments

lib/init-action-post.js

@@ -166096,7 +166096,7 @@ function createOverlayStatus(attributes, checkRunId) {
     workflowRunId: getWorkflowRunID(),
     workflowRunAttempt: getWorkflowRunAttempt(),
     name: getRequiredEnvParam("GITHUB_JOB"),
-    ...checkRunId !== void 0 && { checkRunId }
+    checkRunId
   };
   return {
     ...attributes,
@@ -170374,7 +170374,7 @@ async function recordOverlayStatus(codeql, config, features, logger) {
       attemptedToBuildOverlayBaseDatabase: true,
       builtOverlayBaseDatabase: false
     },
-    Number.isNaN(checkRunId) ? void 0 : checkRunId
+    checkRunId !== void 0 && checkRunId >= 0 ? checkRunId : void 0
   );
   const diskUsage = await checkDiskUsage(logger);
   if (diskUsage === void 0) {

src/init-action-post-helper.test.ts

@@ -374,6 +374,7 @@ test("saves overlay status when overlay-base analysis did not complete successfu
         attemptedToBuildOverlayBaseDatabase: true,
         builtOverlayBaseDatabase: false,
         job: {
+          checkRunId: undefined,
           workflowRunId: 12345,
           workflowRunAttempt: 1,
           name: "analyze",

src/init-action-post-helper.ts

@@ -283,7 +283,7 @@ async function recordOverlayStatus(
       attemptedToBuildOverlayBaseDatabase: true,
       builtOverlayBaseDatabase: false,
     },
-    Number.isNaN(checkRunId) ? undefined : checkRunId,
+    checkRunId !== undefined && checkRunId >= 0 ? checkRunId : undefined,
   );
 
   const diskUsage = await checkDiskUsage(logger);

src/overlay/status.ts

@@ -74,7 +74,7 @@ export function createOverlayStatus(
     workflowRunId: getWorkflowRunID(),
     workflowRunAttempt: getWorkflowRunAttempt(),
     name: getRequiredEnvParam("GITHUB_JOB"),
-    ...(checkRunId !== undefined && { checkRunId }),
+    checkRunId,
   };
   return {
     ...attributes,