Remove unnecessary type assertions

lib/analyze.js

@@ -95,6 +95,10 @@ async function runQueries(sarifFolder, memoryFlag, addSnippetsFlag, threadsFlag,
         }
         try {
             if (hasPackWithCustomQueries) {
+                logger.info("*************");
+                logger.info("Performing analysis with custom QL Packs. QL Packs are an experimental feature.");
+                logger.info("And should not be used in production yet.");
+                logger.info("*************");
                 logger.startGroup(`Downloading custom packs for ${language}`);
                 const codeql = codeql_1.getCodeQL(config.codeQLCmd);
                 const results = await codeql.packDownload(packsWithVersion);
@@ -175,7 +179,7 @@ function createPackSuiteContents(packsWithVersion) {
 function packWithVersionToQuerySuiteEntry(pack) {
     let text = `- qlpack: ${pack.packName}`;
     if (pack.version) {
-        text += `${"\n"}  version: ${pack.version}`;
+        text += `\n  version: ${pack.version}`;
     }
     return text;
 }

lib/config-utils.js

@@ -490,10 +490,11 @@ async function loadConfig(languagesInput, queriesInput, configFile, dbLocation,
     }
     if (shouldAddConfigFileQueries(queriesInput) &&
         QUERIES_PROPERTY in parsedYAML) {
-        if (!Array.isArray(parsedYAML[QUERIES_PROPERTY])) {
+        const queriesArr = parsedYAML[QUERIES_PROPERTY];
+        if (!Array.isArray(queriesArr)) {
             throw new Error(getQueriesInvalid(configFile));
         }
-        for (const query of parsedYAML[QUERIES_PROPERTY]) {
+        for (const query of queriesArr) {
             if (!(QUERIES_USES_PROPERTY in query) ||
                 typeof query[QUERIES_USES_PROPERTY] !== "string") {
                 throw new Error(getQueryUsesInvalid(configFile));

src/analyze.ts

@@ -191,6 +191,12 @@ export async function runQueries(
 
     try {
       if (hasPackWithCustomQueries) {
+        logger.info("*************");
+        logger.info(
+          "Performing analysis with custom QL Packs. QL Packs are an experimental feature."
+        );
+        logger.info("And should not be used in production yet.");
+        logger.info("*************");
         logger.startGroup(`Downloading custom packs for ${language}`);
 
         const codeql = getCodeQL(config.codeQLCmd);
@@ -338,7 +344,7 @@ function packWithVersionToQuerySuiteEntry(
 ): string {
   let text = `- qlpack: ${pack.packName}`;
   if (pack.version) {
-    text += `${"\n"}  version: ${pack.version}`;
+    text += `\n  version: ${pack.version}`;
   }
   return text;
 }

src/config-utils.ts

@@ -845,7 +845,7 @@ export async function getDefaultConfig(
     queries,
     pathsIgnore: [],
     paths: [],
-    packs: {} as Record<Language, PackWithVersion[]>,
+    packs: {},
     originalUserInput: {},
     tempDir,
     toolCacheDir,
@@ -942,10 +942,11 @@ async function loadConfig(
     shouldAddConfigFileQueries(queriesInput) &&
     QUERIES_PROPERTY in parsedYAML
   ) {
-    if (!Array.isArray(parsedYAML[QUERIES_PROPERTY])) {
+    const queriesArr = parsedYAML[QUERIES_PROPERTY];
+    if (!Array.isArray(queriesArr)) {
       throw new Error(getQueriesInvalid(configFile));
     }
-    for (const query of parsedYAML[QUERIES_PROPERTY]!) {
+    for (const query of queriesArr) {
       if (
         !(QUERIES_USES_PROPERTY in query) ||
         typeof query[QUERIES_USES_PROPERTY] !== "string"

src/tracer-config.test.ts

@@ -28,7 +28,7 @@ function getTestConfig(tmpDir: string): configUtils.Config {
     codeQLCmd: "",
     gitHubVersion: { type: util.GitHubVariant.DOTCOM } as util.GitHubVersion,
     dbLocation: path.resolve(tmpDir, "codeql_databases"),
-    packs: {} as configUtils.Packs,
+    packs: {},
   };
 }