mirror of
https://github.com/ipxe/ipxe
synced 2026-01-22 20:19:08 +03:00
05ad7833c5
Almost all image consumers do not need to modify the content of the image. Now that the image data is a pointer type (rather than the opaque userptr_t type), we can rely on the compiler to enforce this at build time. Change the .data field to be a const pointer, so that the compiler can verify that image consumers do not modify the image content. Provide a transparent .rwdata field for consumers who have a legitimate (and now explicit) reason to modify the image content. We do not attempt to impose any runtime restriction on checking whether or not an image is writable. The only existing instances of genuinely read-only images are the various unit test images, and it is acceptable for defective test cases to result in a segfault rather than a runtime error. Signed-off-by: Michael Brown <mcb30@ipxe.org>
81 lines
2.3 KiB
C
81 lines
2.3 KiB
C
/*
|
|
* Copyright (C) 2013 Michael Brown <mbrown@fensystems.co.uk>.
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License as
|
|
* published by the Free Software Foundation; either version 2 of the
|
|
* License, or any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful, but
|
|
* WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
|
|
* 02110-1301, USA.
|
|
*
|
|
* You can also choose to distribute this program under the terms of
|
|
* the Unmodified Binary Distribution Licence (as given in the file
|
|
* COPYING.UBDL), provided that you have satisfied its requirements.
|
|
*/
|
|
|
|
FILE_LICENCE ( GPL2_OR_LATER_OR_UBDL );
|
|
|
|
/** @file
|
|
*
|
|
* Pixel buffer self-tests
|
|
*
|
|
*/
|
|
|
|
/* Forcibly enable assertions */
|
|
#undef NDEBUG
|
|
|
|
#include <string.h>
|
|
#include <assert.h>
|
|
#include <ipxe/image.h>
|
|
#include <ipxe/pixbuf.h>
|
|
#include <ipxe/test.h>
|
|
#include "pixbuf_test.h"
|
|
|
|
/**
|
|
* Report pixel buffer test result
|
|
*
|
|
* @v test Pixel buffer test
|
|
* @v file Test code file
|
|
* @v line Test code line
|
|
*/
|
|
void pixbuf_okx ( struct pixel_buffer_test *test, const char *file,
|
|
unsigned int line ) {
|
|
struct pixel_buffer *pixbuf;
|
|
int rc;
|
|
|
|
/* Sanity check */
|
|
assert ( ( test->width * test->height * sizeof ( test->data[0] ) )
|
|
== test->len );
|
|
|
|
/* Check that image is detected as correct type */
|
|
okx ( register_image ( test->image ) == 0, file, line );
|
|
okx ( test->image->type == test->type, file, line );
|
|
|
|
/* Check that a pixel buffer can be created from the image */
|
|
okx ( ( rc = image_pixbuf ( test->image, &pixbuf ) ) == 0, file, line );
|
|
if ( rc == 0 ) {
|
|
|
|
/* Check pixel buffer dimensions */
|
|
okx ( pixbuf->width == test->width, file, line );
|
|
okx ( pixbuf->height == test->height, file, line );
|
|
|
|
/* Check pixel buffer data */
|
|
okx ( pixbuf->len == test->len, file, line );
|
|
okx ( memcmp ( pixbuf->data, test->data, test->len ) == 0,
|
|
file, line );
|
|
|
|
pixbuf_put ( pixbuf );
|
|
}
|
|
|
|
/* Unregister image */
|
|
unregister_image ( test->image );
|
|
}
|