sysadmin/ipxe
1
0
Fork 0
mirror of https://github.com/ipxe/ipxe synced 2025-12-15 00:12:19 +03:00
Code Issues Packages Projects Releases Wiki Activity

[ena] Fix spurious uninitialised variable warning on older versions of gcc

Browse Source 
Some older versions of gcc (observed with gcc 4.7.2) report a spurious
uninitialised variable warning in ena_get_device_attributes().  Work
around this warning by manually inlining the relevant code (which has
only a single call site).

Reported-by: xbgmsharp <xbgmsharp@gmail.com>
Signed-off-by: Michael Brown <mcb30@ipxe.org>
This commit is contained in:
Michael Brown
2018-01-17 14:09:56 +00:00
parent 70189a8e47
commit fbe8c52d0d
1 changed files with 11 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

46
src/drivers/net/ena.c
View File

@@ -539,35 +539,6 @@ static int ena_destroy_qp ( struct ena_nic *ena, struct ena_qp *qp ) {
return 0; return 0;
} }
/**
* Get feature
*
* @v ena ENA device
* @v id Feature identifier
* @v feature Feature to fill in
* @ret rc Return status code
*/
static int ena_get_feature ( struct ena_nic *ena, unsigned int id,
union ena_feature **feature ) {
union ena_aq_req *req;
union ena_acq_rsp *rsp;
int rc;
/* Construct request */
req = ena_admin_req ( ena );
req->header.opcode = ENA_GET_FEATURE;
req->get_feature.id = id;
/* Issue request */
if ( ( rc = ena_admin ( ena, req, &rsp ) ) != 0 )
return rc;
/* Parse response */
*feature = &rsp->get_feature.feature;
return 0;
}
/** /**
* Get device attributes * Get device attributes
* *
@@ -576,18 +547,23 @@ static int ena_get_feature ( struct ena_nic *ena, unsigned int id,
*/ */
static int ena_get_device_attributes ( struct net_device *netdev ) { static int ena_get_device_attributes ( struct net_device *netdev ) {
struct ena_nic *ena = netdev->priv; struct ena_nic *ena = netdev->priv;
union ena_aq_req *req;
union ena_acq_rsp *rsp;
union ena_feature *feature; union ena_feature *feature;
int rc; int rc;
/* Get device attributes */ /* Construct request */
if ( ( rc = ena_get_feature ( ena, ENA_DEVICE_ATTRIBUTES, req = ena_admin_req ( ena );
&feature ) ) != 0 ) req->header.opcode = ENA_GET_FEATURE;
req->get_feature.id = ENA_DEVICE_ATTRIBUTES;
/* Issue request */
if ( ( rc = ena_admin ( ena, req, &rsp ) ) != 0 )
return rc; return rc;
/* Extract MAC address */ /* Parse response */
feature = &rsp->get_feature.feature;
memcpy ( netdev->hw_addr, feature->device.mac, ETH_ALEN ); memcpy ( netdev->hw_addr, feature->device.mac, ETH_ALEN );
/* Extract MTU */
netdev->max_pkt_len = le32_to_cpu ( feature->device.mtu ); netdev->max_pkt_len = le32_to_cpu ( feature->device.mtu );
DBGC ( ena, "ENA %p MAC %s MTU %zd\n", DBGC ( ena, "ENA %p MAC %s MTU %zd\n",