sysadmin/ipxe
1
0
Fork 0
mirror of https://github.com/ipxe/ipxe synced 2025-12-28 10:32:52 +03:00
Code Issues Packages Projects Releases Wiki Activity

[retry] Use a separate flag to indicate that a retry timer is running

Browse Source 
Using start==0 to indicate a stopped timer is dangerous, because 0 is a
valid value for the current tick counter.
This commit is contained in:
Michael Brown
2008-10-12 15:04:37 +01:00
parent 941b4c2adb
commit f945d6d201
2 changed files with 12 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/include/gpxe/retry.h
View File

@@ -19,6 +19,8 @@
struct retry_timer {
/** List of active timers */
struct list_head list;
/** Timer is currently running */
unsigned int running;
/** Timeout value (in ticks) */
unsigned long timeout;
/** Minimum timeout value (in ticks)
@@ -31,10 +33,7 @@ struct retry_timer {
* A value of zero means "use default timeout."
*/
unsigned long max_timeout;
/** Start time (in ticks)
*
* A start time of zero indicates a stopped timer.
*/
/** Start time (in ticks) */
unsigned long start;
/** Retry count */
unsigned int count;
@@ -74,7 +73,7 @@ static inline void start_timer_nodelay ( struct retry_timer *timer ) {
*/
static inline __attribute__ (( always_inline )) unsigned long
timer_running ( struct retry_timer *timer ) {
return ( timer->start );
return ( timer->running );
}
#endif /* _GPXE_RETRY_H */