sysadmin/ipxe
1
0
Fork 0
mirror of https://github.com/ipxe/ipxe synced 2025-12-24 15:23:42 +03:00
Code Issues Packages Projects Releases Wiki Activity

[settings] Formalise notion of setting applicability

Browse Source 
Expose a function setting_applies() to allow a caller to determine
whether or not a particular setting is applicable to a particular
settings block.

Restrict DHCP-backed settings blocks to accepting only DHCP-based
settings.

Restrict network device settings blocks to accepting only DHCP-based
settings and network device-specific settings such as "mac".

Inspired-by: Glenn Brown <glenn@myri.com>
Signed-off-by: Michael Brown <mcb30@ipxe.org>
This commit is contained in:
Michael Brown
2011-03-22 16:56:35 +00:00
parent 9215b7f4c0
commit f5fd4dec3b
12 changed files with 235 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
src/net/dhcppkt.c
View File

@@ -134,6 +134,19 @@ find_dhcp_packet_field ( unsigned int tag ) {
return NULL;
}
/**
* Check applicability of DHCP setting
*
* @v dhcppkt DHCP packet
* @v tag Setting tag number
* @ret applies Setting applies within this settings block
*/
static int dhcppkt_applies ( struct dhcp_packet *dhcppkt __unused,
unsigned int tag ) {
return dhcpopt_applies ( tag );
}
/**
* Store value of DHCP packet setting
*
@@ -204,6 +217,21 @@ int dhcppkt_fetch ( struct dhcp_packet *dhcppkt, unsigned int tag,
*
*/
/**
* Check applicability of DHCP setting
*
* @v settings Settings block
* @v setting Setting
* @ret applies Setting applies within this settings block
*/
static int dhcppkt_settings_applies ( struct settings *settings,
struct setting *setting ) {
struct dhcp_packet *dhcppkt =
container_of ( settings, struct dhcp_packet, settings );
return dhcppkt_applies ( dhcppkt, setting->tag );
}
/**
* Store value of DHCP setting
*
@@ -242,6 +270,7 @@ static int dhcppkt_settings_fetch ( struct settings *settings,
/** DHCP settings operations */
static struct settings_operations dhcppkt_settings_operations = {
.applies = dhcppkt_settings_applies,
.store = dhcppkt_settings_store,
.fetch = dhcppkt_settings_fetch,
};