sysadmin/ipxe
1
0
Fork 0
mirror of https://github.com/ipxe/ipxe synced 2026-02-14 02:31:26 +03:00
Code Issues Packages Projects Releases Wiki Activity

[ena] Cancel uncompleted transmit buffers on close

Browse Source 
Avoid spurious assertion failures by ensuring that references to
uncompleted transmit buffers are not retained after the device has
been closed.

Signed-off-by: Michael Brown <mcb30@ipxe.org>
This commit is contained in:
Michael Brown
2025-10-16 16:31:03 +01:00
parent dcc5d36ce5
commit e5e371f485
1 changed files with 25 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
src/drivers/net/ena.c
View File

@@ -859,12 +859,32 @@ static void ena_refill_rx ( struct net_device *netdev ) {
* @v ena ENA device * @v ena ENA device
*/ */
static void ena_empty_rx ( struct ena_nic *ena ) { static void ena_empty_rx ( struct ena_nic *ena ) {
struct io_buffer *iobuf;
unsigned int i; unsigned int i;
for ( i = 0 ; i < ENA_RX_COUNT ; i++ ) { for ( i = 0 ; i < ENA_RX_COUNT ; i++ ) {
if ( ena->rx_iobuf[i] ) iobuf = ena->rx_iobuf[i];
free_iob ( ena->rx_iobuf[i] );
ena->rx_iobuf[i] = NULL; ena->rx_iobuf[i] = NULL;
if ( iobuf )
free_iob ( iobuf );
}
}
/**
* Cancel uncompleted transmit I/O buffers
*
* @v netdev Network device
*/
static void ena_cancel_tx ( struct net_device *netdev ) {
struct ena_nic *ena = netdev->priv;
struct io_buffer *iobuf;
unsigned int i;
for ( i = 0 ; i < ENA_TX_COUNT ; i++ ) {
iobuf = ena->tx_iobuf[i];
ena->tx_iobuf[i] = NULL;
if ( iobuf )
netdev_tx_complete_err ( netdev, iobuf, -ECANCELED );
} }
} }
@@ -917,6 +937,9 @@ static void ena_close ( struct net_device *netdev ) {
/* Destroy transmit queue pair */ /* Destroy transmit queue pair */
ena_destroy_qp ( ena, &ena->tx ); ena_destroy_qp ( ena, &ena->tx );
/* Cancel any uncompleted transmit buffers */
ena_cancel_tx ( netdev );
} }
/** /**