sysadmin/ipxe
1
0
Fork 0
mirror of https://github.com/ipxe/ipxe synced 2025-12-23 05:21:49 +03:00
Code Issues Packages Projects Releases Wiki Activity

[params] Use reference counters for form parameter lists

Browse Source 
Signed-off-by: Michael Brown <mcb30@ipxe.org>
This commit is contained in:
Michael Brown
2014-02-25 14:03:40 +00:00
parent 09b057ce84
commit c7b69ac793
4 changed files with 76 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

68
src/core/params.c
View File

@@ -32,6 +32,29 @@ FILE_LICENCE ( GPL2_OR_LATER );
/** List of all parameter lists */
static LIST_HEAD ( parameters );
/**
* Free form parameter list
*
* @v refcnt Reference count
*/
static void free_parameters ( struct refcnt *refcnt ) {
struct parameters *params =
container_of ( refcnt, struct parameters, refcnt );
struct parameter *param;
struct parameter *tmp;
DBGC ( params, "PARAMS \"%s\" destroyed\n", params->name );
/* Free all parameters */
list_for_each_entry_safe ( param, tmp, &params->entries, list ) {
list_del ( &param->list );
free ( param );
}
/* Free parameter list */
free ( params );
}
/**
* Find form parameter list by name
*
@@ -63,14 +86,17 @@ struct parameters * create_parameters ( const char *name ) {
/* Destroy any existing parameter list of this name */
params = find_parameters ( name );
if ( params )
destroy_parameters ( params );
if ( params ) {
claim_parameters ( params );
params_put ( params );
}
/* Allocate parameter list */
name_len = ( name ? ( strlen ( name ) + 1 /* NUL */ ) : 0 );
params = zalloc ( sizeof ( *params ) + name_len );
if ( ! params )
return NULL;
ref_init ( &params->refcnt, free_parameters );
name_copy = ( ( void * ) ( params + 1 ) );
/* Populate parameter list */
@@ -125,41 +151,3 @@ struct parameter * add_parameter ( struct parameters *params,
params->name, param->key, param->value );
return param;
}
/**
* Destroy form parameter list
*
* @v params Parameter list
*/
void destroy_parameters ( struct parameters *params ) {
struct parameter *param;
struct parameter *tmp;
DBGC ( params, "PARAMS \"%s\" destroyed\n", params->name );
/* Free all parameters */
list_for_each_entry_safe ( param, tmp, &params->entries, list ) {
list_del ( &param->list );
free ( param );
}
/* Free parameter list */
list_del ( &params->list );
free ( params );
}
/**
* Claim ownership of form parameter list
*
* @v params Parameter list
*/
void claim_parameters ( struct parameters *params ) {
DBGC ( params, "PARAMS \"%s\" claimed\n", params->name );
/* Remove from list of parameter lists */
list_del ( &params->list );
/* Reinitialise list to allow for subsequent destroy_parameters() */
INIT_LIST_HEAD ( &params->list );
}