sysadmin/ipxe
1
0
Fork 0
mirror of https://github.com/ipxe/ipxe synced 2025-12-30 22:08:48 +03:00
Code Issues Packages Projects Releases Wiki Activity

[netdevice] Allow network devices to disclaim IRQ support at runtime

Browse Source 
VLAN and 802.11 devices use a network device operations structure that
wraps an underlying structure.  For example, the vlan_operations
structure wraps the network device operations structure of the
underlying trunk device.  This can cause false positives from the
current implementation of netdev_irq_supported(), which will always
report that VLAN devices support interrupts since it has no visibility
into the support provided by the underlying trunk device.

Fix by allowing network devices to explicitly flag that interrupts are
not supported, despite the presence of an irq() method.

Originally-fixed-by: Wissam Shoukair <wissams@mellanox.com>
Signed-off-by: Michael Brown <mcb30@ipxe.org>
This commit is contained in:
Michael Brown
2015-07-28 15:05:44 +01:00
parent 76338543f9
commit b20d4a1522
3 changed files with 18 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/net/80211/net80211.c
View File

@@ -805,6 +805,10 @@ int net80211_register ( struct net80211_device *dev,
NET80211_MAX_CHANNELS * sizeof ( dev->channels[0] ) );
dev->channel = 0;
/* Mark device as not supporting interrupts, if applicable */
if ( ! ops->irq )
dev->netdev->state |= NETDEV_IRQ_UNSUPPORTED;
list_add_tail ( &dev->list, &net80211_devices );
return register_netdev ( dev->netdev );
}

4
src/net/vlan.c
View File

@@ -389,6 +389,10 @@ int vlan_create ( struct net_device *trunk, unsigned int tag,
snprintf ( netdev->name, sizeof ( netdev->name ), "%s-%d",
trunk->name, vlan->tag );
/* Mark device as not supporting interrupts, if applicable */
if ( ! netdev_irq_supported ( trunk ) )
netdev->state |= NETDEV_IRQ_UNSUPPORTED;
/* Register VLAN device */
if ( ( rc = register_netdev ( netdev ) ) != 0 ) {
DBGC ( netdev, "VLAN %s could not register: %s\n",