sysadmin/ipxe
1
0
Fork 0
mirror of https://github.com/ipxe/ipxe synced 2026-05-09 18:00:12 +03:00
Code Issues Packages Projects Releases Wiki Activity

[bnxt] Do not abort teardown on command failure

Browse Source 
Modify bnxt_hwrm_run() to accept a flag indicating whether to abort
immediately upon a command failure.  During initialization path,
driver will continue to abort on first error.  During teardown,
sequence will continue executing subsequent cleanup commands even if
one fails.  This ensures a best-effort cleanup.

Signed-off-by: Joseph Wong <joseph.wong@broadcom.com>
This commit is contained in:
Joseph Wong
2026-04-30 14:03:29 -07:00
committed by Michael Brown
parent 822d4b1437
commit ae8defc279
1 changed files with 15 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/drivers/net/bnxt/bnxt.c
+15 -8
View File
@@ -2145,10 +2145,11 @@ hwrm_func_t bring_up_nic[] = {
NULL, NULL,
}; };
int bnxt_hwrm_run ( hwrm_func_t cmds[], struct bnxt *bp ) int bnxt_hwrm_run ( hwrm_func_t cmds[], struct bnxt *bp, int flag )
{ {
hwrm_func_t *ptr; hwrm_func_t *ptr;
int ret; int ret;
u8 Status = 0;
for ( ptr = cmds; *ptr; ++ptr ) { for ( ptr = cmds; *ptr; ++ptr ) {
memset ( ( void * ) REQ_DMA_ADDR ( bp ), 0, REQ_BUFFER_SIZE ); memset ( ( void * ) REQ_DMA_ADDR ( bp ), 0, REQ_BUFFER_SIZE );
@@ -2156,17 +2157,23 @@ int bnxt_hwrm_run ( hwrm_func_t cmds[], struct bnxt *bp )
ret = ( *ptr ) ( bp ); ret = ( *ptr ) ( bp );
if ( ret ) { if ( ret ) {
DBGP ( "- %s ( ): Failed\n", __func__ ); DBGP ( "- %s ( ): Failed\n", __func__ );
return STATUS_FAILURE; Status = STATUS_FAILURE;
// Initialization path failure,
// return failure immediately
// else cleanup the resources
if ( flag )
return STATUS_FAILURE;
} }
} }
return STATUS_SUCCESS; return Status;
} }
#define bnxt_down_chip( bp ) bnxt_hwrm_run ( bring_down_chip, bp ) #define bnxt_down_chip( bp ) bnxt_hwrm_run ( bring_down_chip, bp, 0 )
#define bnxt_up_chip( bp ) bnxt_hwrm_run ( bring_up_chip, bp ) #define bnxt_up_chip( bp ) bnxt_hwrm_run ( bring_up_chip, bp, 1 )
#define bnxt_down_nic( bp ) bnxt_hwrm_run ( bring_down_nic, bp ) #define bnxt_down_nic( bp ) bnxt_hwrm_run ( bring_down_nic, bp, 0 )
#define bnxt_up_nic( bp ) bnxt_hwrm_run ( bring_up_nic, bp ) #define bnxt_up_nic( bp ) bnxt_hwrm_run ( bring_up_nic, bp, 1 )
#define bnxt_up_init( bp ) bnxt_hwrm_run ( bring_up_init, bp ) #define bnxt_up_init( bp ) bnxt_hwrm_run ( bring_up_init, bp, 1 )
static int bnxt_open ( struct net_device *dev ) static int bnxt_open ( struct net_device *dev )
{ {