sysadmin/ipxe
1
0
Fork 0
mirror of https://github.com/ipxe/ipxe synced 2026-02-14 02:31:26 +03:00
Code Issues Packages Projects Releases Wiki Activity

[image] Clear recorded replacement image immediately after consuming

Browse Source 
If an embedded script uses "chain --replace", the embedded image will
retain a reference to the replacement image in perpetuity.

Fix by clearing any recorded replacement image immediately in
image_exec(), instead of relying upon image_free() to drop the
reference.

Signed-off-by: Michael Brown <mcb30@ipxe.org>
This commit is contained in:
Michael Brown
2025-04-29 16:28:03 +01:00
parent 9962c0a58f
commit a69c42dd9f
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/core/image.c
View File

@@ -447,6 +447,10 @@ int image_exec ( struct image *image ) {
if ( replacement ) if ( replacement )
assert ( replacement->flags & IMAGE_REGISTERED ); assert ( replacement->flags & IMAGE_REGISTERED );
/* Clear any recorded replacement image */
image_put ( image->replacement );
image->replacement = NULL;
err: err:
/* Unregister image if applicable */ /* Unregister image if applicable */
if ( image->flags & IMAGE_AUTO_UNREGISTER ) if ( image->flags & IMAGE_AUTO_UNREGISTER )