sysadmin/ipxe
1
0
Fork 0
mirror of https://github.com/ipxe/ipxe synced 2025-12-12 23:15:10 +03:00
Code Issues Packages Projects Releases Wiki Activity

[iscsi] Add missing "break" statements

Browse Source 
iscsi_tx_done() is missing "break" statements at the end of each case.
(Fortunately, this happens not to cause a bug in practice, since
iscsi_login_request_done() is effectively a no-op when completing a
data-out PDU.)

Reported-by: Wissam Shoukair <wissams@mellanox.com>
Signed-off-by: Michael Brown <mcb30@ipxe.org>
This commit is contained in:
Michael Brown
2015-07-28 14:11:35 +01:00
parent 2bcf13f13a
commit 76338543f9
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/net/tcp/iscsi.c
View File

@@ -1439,8 +1439,10 @@ static void iscsi_tx_done ( struct iscsi_session *iscsi ) {
switch ( common->opcode & ISCSI_OPCODE_MASK ) { switch ( common->opcode & ISCSI_OPCODE_MASK ) {
case ISCSI_OPCODE_DATA_OUT: case ISCSI_OPCODE_DATA_OUT:
iscsi_data_out_done ( iscsi ); iscsi_data_out_done ( iscsi );
break;
case ISCSI_OPCODE_LOGIN_REQUEST: case ISCSI_OPCODE_LOGIN_REQUEST:
iscsi_login_request_done ( iscsi ); iscsi_login_request_done ( iscsi );
break;
default: default:
/* No action */ /* No action */
break; break;