sysadmin/ipxe
1
0
Fork 0
mirror of https://github.com/ipxe/ipxe synced 2025-12-22 21:11:03 +03:00
Code Issues Packages Projects Releases Wiki Activity

[iscsi] Accept NOP-In PDUs sent by the target

Browse Source 
Some iSCSI targets (observed with a Synology DS207+ NAS) send
unsolicited NOP-Ins to the initiator.  RFC 3720 is remarkably unclear
and possibly self-contradictory on how NOPs are supposed to work, but
it seems as though we can legitimately just ignore any unsolicited
NOP-In PDU.

Reported-by: Marc Lecuyer <marc@maxiscreen.com>
Originally-implemented-by: Thomas Miletich <thomas.miletich@gmail.com>
Signed-off-by: Michael Brown <mcb30@ipxe.org>
This commit is contained in:
Michael Brown
2011-02-24 13:22:20 +00:00
parent 030e5a064e
commit 711df439df
2 changed files with 84 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
src/include/ipxe/iscsi.h
View File

@@ -93,6 +93,9 @@ struct iscsi_bhs_common {
/** iSCSI tag magic marker */
#define ISCSI_TAG_MAGIC 0x18ae0000
/** iSCSI reserved tag value */
#define ISCSI_TAG_RESERVED 0xffffffff
/**
* iSCSI basic header segment common request fields
*
@@ -455,6 +458,36 @@ struct iscsi_bhs_r2t {
/** R2T opcode */
#define ISCSI_OPCODE_R2T 0x31
/**
* iSCSI NOP-In basic header segment
*
*/
struct iscsi_nop_in {
/** Opcode */
uint8_t opcode;
/** Reserved */
uint8_t reserved_a[3];
/** Segment lengths */
union iscsi_segment_lengths lengths;
/** Logical Unit Number */
struct scsi_lun lun;
/** Initiator Task Tag */
uint32_t itt;
/** Target Transfer Tag */
uint32_t ttt;
/** Status sequence number */
uint32_t statsn;
/** Expected command sequence number */
uint32_t expcmdsn;
/** Maximum command sequence number */
uint32_t maxcmdsn;
/** Reserved */
uint8_t reserved_b[12];
};
/** NOP-In opcode */
#define ISCSI_OPCODE_NOP_IN 0x20
/**
* An iSCSI basic header segment
*/
@@ -468,6 +501,7 @@ union iscsi_bhs {
struct iscsi_bhs_data_in data_in;
struct iscsi_bhs_data_out data_out;
struct iscsi_bhs_r2t r2t;
struct iscsi_nop_in nop_in;
unsigned char bytes[ sizeof ( struct iscsi_bhs_common ) ];
};