sysadmin/ipxe
1
0
Fork 0
mirror of https://github.com/ipxe/ipxe synced 2025-12-23 13:30:57 +03:00
Code Issues Packages Projects Releases Wiki Activity

[refcnt] Check reference validity on each use of ref_get() and ref_put()

Browse Source 
Check that the reference count is valid (i.e. non-negative) on each
call to ref_get() and ref_put(), using an assert() at the point of
use.

Signed-off-by: Michael Brown <mcb30@ipxe.org>
This commit is contained in:
Michael Brown
2010-11-05 22:24:46 +00:00
parent fc69ab94d9
commit 6e41f2cf18
2 changed files with 52 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
src/core/refcnt.c
View File

@@ -31,18 +31,16 @@ FILE_LICENCE ( GPL2_OR_LATER );
* Increment reference count
*
* @v refcnt Reference counter, or NULL
* @ret refcnt Reference counter
*
* If @c refcnt is NULL, no action is taken.
*/
struct refcnt * ref_get ( struct refcnt *refcnt ) {
void ref_increment ( struct refcnt *refcnt ) {
if ( refcnt ) {
refcnt->refcnt++;
refcnt->count++;
DBGC2 ( refcnt, "REFCNT %p incremented to %d\n",
refcnt, refcnt->refcnt );
refcnt, refcnt->count );
}
return refcnt;
}
/**
@@ -55,18 +53,28 @@ struct refcnt * ref_get ( struct refcnt *refcnt ) {
*
* If @c refcnt is NULL, no action is taken.
*/
void ref_put ( struct refcnt *refcnt ) {
void ref_decrement ( struct refcnt *refcnt ) {
if ( ! refcnt )
return;
refcnt->refcnt--;
refcnt->count--;
DBGC2 ( refcnt, "REFCNT %p decremented to %d\n",
refcnt, refcnt->refcnt );
refcnt, refcnt->count );
if ( refcnt->refcnt >= 0 )
if ( refcnt->count >= 0 )
return;
if ( refcnt->count < -1 ) {
DBGC ( refcnt, "REFCNT %p decremented too far (%d)!\n",
refcnt, refcnt->count );
/* Avoid multiple calls to free(), which typically
* result in memory corruption that is very hard to
* track down.
*/
return;
}
if ( refcnt->free ) {
DBGC ( refcnt, "REFCNT %p being freed via method %p\n",
refcnt, refcnt->free );