sysadmin/ipxe
1
0
Fork 0
mirror of https://github.com/ipxe/ipxe synced 2026-02-14 02:31:26 +03:00
Code Issues Packages Projects Releases Wiki Activity

[pcbios] Save/restore %es in INT 15,e820

Browse Source 
Our INT 15,e820 code was setting %es=%ss (as part of the "look ahead
in the memory map" logic), but failing to restore %es afterwards.
This is a serious bug, but wasn't affecting many platforms because
almost all callers seem to set %es=%ss anyway.
This commit is contained in:
Michael Brown
2008-09-29 00:36:11 +01:00
parent e3c5507178
commit 50dc9344b7
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/arch/i386/firmware/pcbios/e820mangler.S
View File

@@ -436,6 +436,7 @@ get_mangled_e820:
/* Peek ahead to see if there are any further nonempty regions */ /* Peek ahead to see if there are any further nonempty regions */
pushal pushal
pushw %es
subw $20, %sp subw $20, %sp
movl $0xe820, %eax movl $0xe820, %eax
movl $SMAP, %edx movl $SMAP, %edx
@@ -445,6 +446,7 @@ get_mangled_e820:
movw %sp, %di movw %sp, %di
call get_nonempty_e820 call get_nonempty_e820
addr32 leal 20(%esp), %esp /* avoid changing flags */ addr32 leal 20(%esp), %esp /* avoid changing flags */
popw %es
popal popal
jnc 99f /* There are further nonempty regions */ jnc 99f /* There are further nonempty regions */