sysadmin/ipxe
1
0
Fork 0
mirror of https://github.com/ipxe/ipxe synced 2026-01-09 13:42:25 +03:00
Code Issues Packages Projects Releases Wiki Activity

[efi] Avoid unnecessarily passing pointers to EFI_HANDLEs

Browse Source 
efi_file_install() and efi_download_install() are both used to install
onto existing handles.  There is therefore no need to allow for each
of their calls to InstallMultipleProtocolInterfaces() to create a new
handle.

By passing the handle directly (rather than a pointer to the handle),
we avoid potential confusion (and erroneous debug message colours).

Signed-off-by: Michael Brown <mcb30@ipxe.org>
This commit is contained in:
Michael Brown
2014-07-31 12:22:40 +01:00
parent 88bd71a27a
commit 4a480f1d15
5 changed files with 14 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/interface/efi/efi_download.c
View File

@@ -205,13 +205,13 @@ static IPXE_DOWNLOAD_PROTOCOL ipxe_download_protocol_interface = {
* @v handle EFI handle
* @ret rc Return status code
*/
int efi_download_install ( EFI_HANDLE *handle ) {
int efi_download_install ( EFI_HANDLE handle ) {
EFI_BOOT_SERVICES *bs = efi_systab->BootServices;
EFI_STATUS efirc;
int rc;
efirc = bs->InstallMultipleProtocolInterfaces (
handle,
&handle,
&ipxe_download_protocol_guid,
&ipxe_download_protocol_interface,
NULL );