sysadmin/ipxe
1
0
Fork 0
mirror of https://github.com/ipxe/ipxe synced 2026-01-30 04:58:12 +03:00
Code Issues Packages Projects Releases Wiki Activity

[efi] Fix Coverity warning about unintended sign extension

Browse Source 
The result of multiplying a uint16_t by another uint16_t will be a
signed int.  Comparing this against a size_t will perform an unwanted
sign extension.

Fix by explicitly casting e_phnum to an unsigned int, thereby matching
the data type used for the loop index variable (and avoiding the
unwanted sign extension).

This mirrors wimboot commit 15f6162 ("[efi] Fix Coverity warning about
unintended sign extension").

Signed-off-by: Michael Brown <mcb30@ipxe.org>
This commit is contained in:
Michael Brown
2023-12-19 16:56:34 +00:00
parent 0958e01463
commit 3fc1b407d2
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/util/elf2efi.c
View File

@@ -440,8 +440,8 @@ static void read_elf_file ( const char *name, struct elf_file *elf ) {
/* Check program headers */ /* Check program headers */
if ( ( elf->len < ehdr->e_phoff ) || if ( ( elf->len < ehdr->e_phoff ) ||
( ( elf->len - ehdr->e_phoff ) < ( ehdr->e_phnum * ( ( elf->len - ehdr->e_phoff ) <
ehdr->e_phentsize ) ) ) { ( ( ( unsigned int ) ehdr->e_phnum ) * ehdr->e_phentsize ) ) ) {
eprintf ( "ELF program headers outside file in %s\n", name ); eprintf ( "ELF program headers outside file in %s\n", name );
exit ( 1 ); exit ( 1 );
} }