sysadmin/ipxe
1
0
Fork 0
mirror of https://github.com/ipxe/ipxe synced 2026-02-03 06:34:32 +03:00
Code Issues Packages Projects Releases Wiki Activity

[xen] Set the "feature-rx-notify" flag for netfront devices

Browse Source 
iPXE already sends RX notifications to the backend when needed, but
does not set the "feature-rx-notify" flag.  As of XenServer 6.5, this
flag is mandatory and omitting it will cause the backend to fail.

Fix by setting the "feature-rx-notify" flag, to inform the backend
that we will send notifications.

Reported-by: Shalom Bhooshi <shalom.bhooshi@citrix.com>
Signed-off-by: Michael Brown <mcb30@ipxe.org>
This commit is contained in:
Michael Brown
2015-03-06 17:19:09 +00:00
parent e905cdcce3
commit 3eb91209d9
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/drivers/net/netfront.c
View File

@@ -597,6 +597,11 @@ static int netfront_open ( struct net_device *netdev ) {
"feature-no-csum-offload" ) ) != 0 ) "feature-no-csum-offload" ) ) != 0 )
goto err_feature_no_csum_offload; goto err_feature_no_csum_offload;
/* Inform backend that we will send notifications for RX requests */
if ( ( rc = netfront_write_flag ( netfront,
"feature-rx-notify" ) ) != 0 )
goto err_feature_rx_notify;
/* Set state to Connected */ /* Set state to Connected */
if ( ( rc = xenbus_set_state ( xendev, XenbusStateConnected ) ) != 0 ) { if ( ( rc = xenbus_set_state ( xendev, XenbusStateConnected ) ) != 0 ) {
DBGC ( netfront, "NETFRONT %s could not set state=\"%d\": %s\n", DBGC ( netfront, "NETFRONT %s could not set state=\"%d\": %s\n",
@@ -622,6 +627,8 @@ static int netfront_open ( struct net_device *netdev ) {
err_backend_wait: err_backend_wait:
netfront_reset ( netfront ); netfront_reset ( netfront );
err_set_state: err_set_state:
netfront_rm ( netfront, "feature-rx-notify" );
err_feature_rx_notify:
netfront_rm ( netfront, "feature-no-csum-offload" ); netfront_rm ( netfront, "feature-no-csum-offload" );
err_feature_no_csum_offload: err_feature_no_csum_offload:
netfront_rm ( netfront, "request-rx-copy" ); netfront_rm ( netfront, "request-rx-copy" );
@@ -665,6 +672,7 @@ static void netfront_close ( struct net_device *netdev ) {
} }
/* Delete flags */ /* Delete flags */
netfront_rm ( netfront, "feature-rx-notify" );
netfront_rm ( netfront, "feature-no-csum-offload" ); netfront_rm ( netfront, "feature-no-csum-offload" );
netfront_rm ( netfront, "request-rx-copy" ); netfront_rm ( netfront, "request-rx-copy" );