sysadmin/ipxe
1
0
Fork 0
mirror of https://github.com/ipxe/ipxe synced 2026-02-14 02:31:26 +03:00
Code Issues Packages Projects Releases Wiki Activity

[xsigo] Avoid storing unused uninitialised fields in gateway address

Browse Source 
As reported by Coverity, xsmp_rx_xve_modify() currently passes a
partially initialised struct ib_address_vector to xve_update_tca() and
thence to eoib_set_gateway(), which uses memcpy() to store the whole
structure including the (unused and unneeded) uninitialised fields.

Silence the Coverity warning by zeroing the whole structure.

Signed-off-by: Michael Brown <mcb30@ipxe.org>
This commit is contained in:
Michael Brown
2022-02-16 13:22:56 +00:00
parent 04288974f6
commit 252cff5e9a
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/net/infiniband/xsigo.c
View File

@@ -870,6 +870,7 @@ static int xsmp_rx_xve_modify ( struct xsigo_manager *xcm,
* erroneously transmitted as little-endian. * erroneously transmitted as little-endian.
*/ */
mtu = ntohs ( msg->mtu ); mtu = ntohs ( msg->mtu );
memset ( &tca, 0, sizeof ( tca ) );
tca.qpn = ntohl ( msg->tca.data ); tca.qpn = ntohl ( msg->tca.data );
tca.qkey = ntohs ( msg->tca.qkey ); tca.qkey = ntohs ( msg->tca.qkey );
tca.gid_present = 1; tca.gid_present = 1;