sysadmin/ipxe
1
0
Fork 0
mirror of https://github.com/ipxe/ipxe synced 2025-12-08 02:10:25 +03:00
Code Issues Packages Projects Releases Wiki Activity

[build] Work around stray sections introduced by some binutils versions

Browse Source 
Some versions of GNU ld (observed with binutils 2.36 on Arch Linux)
introduce a .note.gnu.property section marked as loadable at a high
address and with non-empty contents.  This adds approximately 128MB of
garbage to the BIOS .usb disk images.

Fix by using a custom linker script for the prefix-only binaries such
as the USB disk partition table and MBR, in order to allow unwanted
sections to be explicitly discarded.

Reported-by: Christian Hesse <mail@eworm.de>
Tested-by: Christian Hesse <mail@eworm.de>
Signed-off-by: Michael Brown <mcb30@ipxe.org>
This commit is contained in:
Michael Brown
2021-02-15 09:54:03 +00:00
parent 83516ba7f0
commit 1b99ba2a93
2 changed files with 33 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/arch/x86/Makefile.pcbios
View File

@@ -4,18 +4,15 @@
# #
SRCDIRS += arch/x86/drivers/net SRCDIRS += arch/x86/drivers/net
# The i386 linker script # The linker scripts
# #
LDSCRIPT = arch/x86/scripts/pcbios.lds LDSCRIPT = arch/x86/scripts/pcbios.lds
LDSCRIPT_PREFIX = arch/x86/scripts/prefixonly.lds
# Stop ld from complaining about our customised linker script # Stop ld from complaining about our customised linker script
# #
LDFLAGS += -N --no-check-sections LDFLAGS += -N --no-check-sections
# Prefix always starts at address zero
#
LDFLAGS += --section-start=.prefix=0
# Media types. # Media types.
# #
MEDIA += rom MEDIA += rom
@@ -73,12 +70,12 @@ NON_AUTO_MEDIA += fd0
# Special target for building Master Boot Record binary # Special target for building Master Boot Record binary
$(BIN)/mbr.tmp : $(BIN)/mbr.o $(BIN)/mbr.tmp : $(BIN)/mbr.o
$(QM)$(ECHO) " [LD] $@" $(QM)$(ECHO) " [LD] $@"
$(Q)$(LD) $(LDFLAGS) -o $@ -e mbr $< $(Q)$(LD) $(LDFLAGS) -T $(LDSCRIPT_PREFIX) -o $@ -e mbr $<
# rule to make a USB disk image # rule to make a USB disk image
$(BIN)/usbdisk.tmp : $(BIN)/usbdisk.o $(BIN)/usbdisk.tmp : $(BIN)/usbdisk.o
$(QM)$(ECHO) " [LD] $@" $(QM)$(ECHO) " [LD] $@"
$(Q)$(LD) $(LDFLAGS) -o $@ -e mbr $< $(Q)$(LD) $(LDFLAGS) -T $(LDSCRIPT_PREFIX) -o $@ -e mbr $<
NON_AUTO_MEDIA += usb NON_AUTO_MEDIA += usb
%usb: $(BIN)/usbdisk.bin %hd %usb: $(BIN)/usbdisk.bin %hd

29
src/arch/x86/scripts/prefixonly.lds Normal file
View File

@@ -0,0 +1,29 @@
/* -*- ld-script -*- */
/*
* Linker script for prefix-only binaries (e.g. USB disk MBR)
*
*/
SECTIONS {
.prefix 0x0 : AT ( 0x0 ) {
*(.prefix)
}
/DISCARD/ : {
*(.comment)
*(.comment.*)
*(.note)
*(.note.*)
*(.eh_frame)
*(.eh_frame.*)
*(.rel)
*(.rel.*)
*(.einfo)
*(.einfo.*)
*(.discard)
*(.discard.*)
}
}