actions/octokit.py
1
0
Fork 0
mirror of https://github.com/khornberg/octokit.py synced 2026-05-15 05:02:32 +03:00
Code Issues Packages Projects Releases Wiki Activity

Bug Fix: Return copy of self instead of self

Browse Source 
If one had a single reference object, that object would be mutated
unknowningly.

Example:

repo = octokit.repos.repo(...)
repo.issues.create(...)

repo now is the response of the created issue not the getting of the
repo.
This commit is contained in:
Kyle Hornberg
2018-03-12 15:10:10 -05:00
parent 725d8ef186
commit a80ca34f06
2 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/test_methods.py
+4 -2
View File
@@ -144,15 +144,17 @@ class TestClientMethods(object):
}
)
def test_returned_object_is_self(self, mocker):
def test_returned_object_is_not_self_but_a_copy_of_self(self, mocker):
mocker.patch('requests.patch')
headers = {'accept': 'application/vnd.github.squirrel-girl-preview', 'Content-Type': 'application/json'}
data = {'state': 'open'}
sut = Octokit().issues.edit(owner='testUser', repo='testRepo', number=1)
octokit = Octokit()
sut = octokit.issues.edit(owner='testUser', repo='testRepo', number=1)
requests.patch.assert_called_once_with(
'https://api.github.com/repos/testUser/testRepo/issues/1', data=json.dumps(data), headers=headers
)
assert sut.__class__.__name__ == 'Octokit'
assert sut != octokit
def test_returned_object_has_requests_response_object(self, mocker):
patch = mocker.patch('requests.patch')